Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a distinct emails import view name to avoid cache conflicts #6076

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Set a distinct emails import view name to avoid cache conflicts #6076

merged 2 commits into from
Jul 24, 2018

Conversation

PedroErnst
Copy link
Contributor

@PedroErnst PedroErnst commented Jun 25, 2018 •
edited

Provides a distinct name for the Import View cache file to avoid using the same cache file as regular edit view.

Description

Fix #6050

How To Test This

  1. Repair and Rebuild
  2. Go to Emails
  3. Import an Email
  4. Edit the imported Email
  5. See buttons appear

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

codecov-io commented Jun 25, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (hotfix@07660a7). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             hotfix    #6076   +/-   ##
=========================================
  Coverage          ?    7.15%           
=========================================
  Files             ?     3400           
  Lines             ?   338736           
  Branches          ?        0           
=========================================
  Hits              ?    24237           
  Misses            ?   314499           
  Partials          ?        0

e-reeley
e-reeley approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@e-reeley e-reeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PedroErnst PedroErnst changed the title Set a distinct emails import view name to avoid cache conflicts WIP: Set a distinct emails import view name to avoid cache conflicts Jun 29, 2018
@PedroErnst PedroErnst mentioned this pull request Jul 4, 2018
Closed
@PedroErnst PedroErnst changed the title WIP: Set a distinct emails import view name to avoid cache conflicts Set a distinct emails import view name to avoid cache conflicts Jul 17, 2018
Merge branch 'hotfix' of https://github.com/salesagility/SuiteCRM int…
6993a12 
…o fix/6050-emails-edit-buttons

# Conflicts:
#	modules/Emails/views/view.import.php
@Dillon-Brown Dillon-Brown added Status:Requires Automated Tests Suggestion to OP to provide automated testing (unit, or acceptance) and removed Status:Requires Automated Tests Suggestion to OP to provide automated testing (unit, or acceptance) labels Jul 24, 2018
@Dillon-Brown
Copy link
Contributor

Dillon-Brown commented Jul 24, 2018 •
edited by mattlorimer

Assessed

Approved with PullApprove

@Dillon-Brown Dillon-Brown added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Jul 24, 2018
@Dillon-Brown Dillon-Brown merged commit 6915ec4 into salesagility:hotfix Jul 24, 2018
@gymad gymad mentioned this pull request Sep 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-samson daniel-samson daniel-samson approved these changes

@e-reeley e-reeley e-reeley approved these changes

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PedroErnst @codecov-io @Dillon-Brown @daniel-samson @e-reeley